Merged
Conversation
* Add tests (and test data) for SARIX and GBQR for NSSP data source * Rename tests and test data to specify the main data source (i.e. NHSN or NSSP) * Update file paths in tests to be dynamic (not hard-coded)
nickreich
reviewed
Oct 21, 2025
nickreich
reviewed
Oct 21, 2025
trobacker
reviewed
Oct 23, 2025
matthewcornell
previously approved these changes
Oct 28, 2025
* Refactor gbqr tests to create configs with helpers * Add more gbqr tests + update test data
* Update sarix fourier tests to use separate states and hsas fields, same logic as other tests, config creation helpers when applicable * Add args to config creation helper methods to be more flexible
matthewcornell
previously approved these changes
Nov 19, 2025
Member
matthewcornell
left a comment
matthewcornell
left a comment
There was a problem hiding this comment.
I didn't do a deep dive into the logic, but it looks good from a quick-ish scan. Exciting!
nickreich
previously approved these changes
Nov 19, 2025
Better match original code + Avoid error whenNot all requested locations in data
lshandross
dismissed stale reviews from nickreich and matthewcornell
via
a63d488
New functionality added: allow NSSP-based forecasting Breaking change: run_config.locations superseded by run_config.states and run_config.hsas
nickreich
approved these changes
Nov 24, 2025
Member
nickreich
left a comment
nickreich
left a comment
There was a problem hiding this comment.
LGTM! thanks for the iteration.
nickreich
added a commit
that referenced
this pull request
Dec 8, 2025
Documents the NSSP data source support added in PR #14, including: - NSSP data source support for SARIX and GBQR models - HSA and state-level forecasting - Breaking change: locations replaced by states/hsas config Also adds codespell config to ignore "HSA" acronym. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the SARIX and GBQR model classes to take NSSP as a data source, as well as the tests/test data to test the new functionality. Likely most easily reviewed by looking at individual commits, and I could also walk someone through it if need be